Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default value for sonar.sources #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

UgVo
Copy link

@UgVo UgVo commented May 21, 2024

Description

Sonar already sets the sonar.sources to the base directory, as such there is non reason to force it as well in the action script. Moreover it overrides any attempt to set it from the properties file, preventing source filtering.

Related Issue

Fixes #45

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

How Has This Been Tested?

  • Set up the property sonar.sources in a file sonar-project.properties to filter only some of the folder of a project (tested with multiple combinaisons)
  • Run the action
  • Check that the filter worked as expected (for every combinaisons)

By default sonar sets `sonar.source` to the basedirectory, as such there is no reason to set it up here. Moreover it overrides any attempt to set it from the properties file

Signed-off-by: Ug.Vo <[email protected]>
@UgVo UgVo changed the title Remove default value for sonar.sources and password input (deprecated by sonarqube) Remove default value for sonar.sources May 21, 2024
@UgVo UgVo marked this pull request as ready for review May 21, 2024 15:10
@UgVo UgVo requested a review from dwisiswant0 as a code owner May 21, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property sonar.sources ignored
1 participant